[MSA] Fix arg parsing in main #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please target the |
tylerjw
approved these changes
Mar 11, 2022
Codecov Report
@@ Coverage Diff @@
## feature/msa #1110 +/- ##
===============================================
- Coverage 61.03% 61.02% -0.01%
===============================================
Files 275 275
Lines 23761 23761
===============================================
- Hits 14501 14498 -3
- Misses 9260 9263 +3
Continue to review full report at Codecov.
|
vatanaksoytezer
approved these changes
Mar 15, 2022
DLu
added a commit
to DLu/moveit2
that referenced
this pull request
May 19, 2022
vatanaksoytezer
pushed a commit
that referenced
this pull request
May 25, 2022
vatanaksoytezer
pushed a commit
that referenced
this pull request
May 31, 2022
vatanaksoytezer
pushed a commit
that referenced
this pull request
May 31, 2022
DLu
added a commit
to DLu/moveit2
that referenced
this pull request
Jun 13, 2022
DLu
added a commit
to DLu/moveit2
that referenced
this pull request
Jun 13, 2022
vatanaksoytezer
pushed a commit
that referenced
this pull request
Jun 14, 2022
peterdavidfagan
pushed a commit
to peterdavidfagan/moveit2
that referenced
this pull request
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the parsing of command line arguments, so that launching MSA from a launch file does not result in an "unknown argument --ros-args" error.
It feels like there should be an easier way to do this, but this is the best I found.
Checklist